Stefan Hildebrandt
e1e83c4a83
The single `forceSync` + assert pattern flaked under full-suite load: one reconcile can miss (or a shared/cross-account counter refresh lands late) with no retry, so the assertion polls stale DOM until timeout. The flake moved between reconcile-dependent tests (server-side move, spam source drain, unified / shared counters) run to run. - Add expectFolderCountsSynced(): nudges a reconcile (visibilitychange -> checkForStateChanges) before *every* poll, so a missed reconcile is retried for the full window. Compares only the provided unread/total fields. - Use it for the reconcile-dependent counter checks in 02 (move/delete), 03 (multi-account isolation + unified aggregation), 04 (All Mail), 05 (spam source), 06 (shared folders); drop the now-redundant standalone forceSync. Pure live-push assertions (incoming/burst, background-login-live) keep the plain helpers so they still prove push works. - The spam->not-spam round-trip could stall the Junk badge reconcile even with retries under load; assert the optimistic list removal + authoritative server round-trip (out of Junk, back in Inbox) instead of the badge. Validated with two back-to-back full-suite runs: 35 passed each.
97 lines
3.3 KiB
TypeScript
97 lines
3.3 KiB
TypeScript
import { test, expect } from '@playwright/test';
|
|
import { ACCOUNTS } from './helpers/config';
|
|
import { sendMail } from './helpers/smtp';
|
|
import { JmapClient } from './helpers/jmap';
|
|
import {
|
|
login,
|
|
addAccount,
|
|
seedAllMailSettings,
|
|
folderRow,
|
|
openFolder,
|
|
expectFolderCountsSynced,
|
|
expectEmailVisible,
|
|
emailItem,
|
|
forceSync,
|
|
} from './helpers/app';
|
|
|
|
/**
|
|
* The "All Mail" view — a virtual folder that merges messages across an
|
|
* account's folders (Inbox + custom, excluding junk/sent/trash/drafts/archive),
|
|
* and across every logged-in account when the cross-account sub-option is on.
|
|
*/
|
|
const { alice, bob } = ACCOUNTS;
|
|
const ALL_MAIL = '__cross_all__';
|
|
|
|
let seq = 0;
|
|
const subj = (l: string) => `IT ${l} ${Date.now()}-${seq++}`;
|
|
const send = (to: typeof alice, subject: string) =>
|
|
sendMail({ from: to.email, authPass: to.password, to: to.email, subject, body: 'x' });
|
|
|
|
test.describe('All Mail — single account', () => {
|
|
let jmap: JmapClient;
|
|
|
|
test.beforeEach(async () => {
|
|
jmap = await JmapClient.connect(alice.email, alice.password);
|
|
await jmap.reset();
|
|
});
|
|
|
|
test('merges Inbox + custom folders and excludes Junk', async ({ page }) => {
|
|
const inboxSubj = subj('am-inbox');
|
|
const folderSubj = subj('am-folder');
|
|
const junkSubj = subj('am-junk');
|
|
await send(alice, inboxSubj);
|
|
await send(alice, folderSubj);
|
|
await send(alice, junkSubj);
|
|
|
|
// File one into a custom folder and one into Junk (excluded from All Mail).
|
|
const folderMail = await jmap.waitForEmail(folderSubj);
|
|
await jmap.moveEmailToFolder(folderMail.id, 'Projects');
|
|
const junkMail = await jmap.waitForEmail(junkSubj);
|
|
const junk = await jmap.mailboxByRole('junk');
|
|
await jmap.moveEmail(junkMail.id, junk!.id);
|
|
|
|
await seedAllMailSettings(page, { crossAccount: false });
|
|
await login(page, alice);
|
|
|
|
// The All Mail entry is present and shows the two included-folder unreads.
|
|
await expect(folderRow(page, { name: ALL_MAIL }).first()).toBeVisible();
|
|
await expectFolderCountsSynced(page, { name: ALL_MAIL }, { unread: 2 });
|
|
|
|
// Its list merges the Inbox and custom-folder messages, but not Junk.
|
|
await openFolder(page, { name: ALL_MAIL });
|
|
await forceSync(page);
|
|
await expectEmailVisible(page, inboxSubj);
|
|
await expectEmailVisible(page, folderSubj);
|
|
await expect(emailItem(page, junkSubj)).toHaveCount(0);
|
|
});
|
|
});
|
|
|
|
test.describe('All Mail — cross account', () => {
|
|
test.beforeEach(async () => {
|
|
for (const a of [alice, bob]) {
|
|
const j = await JmapClient.connect(a.email, a.password);
|
|
await j.reset();
|
|
}
|
|
});
|
|
|
|
test('merges mail from every logged-in account', async ({ page }) => {
|
|
const aSubj = subj('am-a');
|
|
const bSubj = subj('am-b');
|
|
await send(alice, aSubj);
|
|
await send(bob, bSubj);
|
|
|
|
await seedAllMailSettings(page, { crossAccount: true });
|
|
await login(page, alice);
|
|
await addAccount(page, bob);
|
|
|
|
// All Mail aggregates unread across both accounts (alice 1 + bob 1).
|
|
await expect(folderRow(page, { name: ALL_MAIL }).first()).toBeVisible();
|
|
await expectFolderCountsSynced(page, { name: ALL_MAIL }, { unread: 2 });
|
|
|
|
await openFolder(page, { name: ALL_MAIL });
|
|
await forceSync(page);
|
|
await expectEmailVisible(page, aSubj);
|
|
await expectEmailVisible(page, bSubj);
|
|
});
|
|
});
|