Files
SRCmail/stores/__tests__/auth-store-logout.test.ts
T
dealerwebandLinus Rath 38a396d150 Fix: end refresh loops on sign-out and back off failed retries
Fixes #588.

Sign-out already cleared the token-refresh timers and stopped the
keep-alive interval - the reported endless loops came from async
callbacks that were in flight at that moment. The token refresh's
failure handler re-armed its retry after logout, and a failing
keep-alive ping called reconnect() -> connect(), which restarts the
keep-alive and thereby revived the interval disconnect() had just
stopped. Only closing the tab ended it.

Two mechanisms fix that class: transiently failed token refreshes only
re-arm while the account is still signed in (checked when the failure
lands, not when the request started), and the client carries an
intentionallyDisconnected flag set by disconnect() - the ping callback,
reconnect(), the SSE reconnect scheduling and the polling fallback all
stop at it, so nothing revives after an intentional sign-out.

Failed retries also back off instead of hammering a down server every
30 seconds: the token refresh climbs 30s/1m/2m/5m (capped, reset on
success), and the keep-alive skips upcoming ticks on consecutive
failures for the same effective ladder. Recovery after an outage is
unchanged in substance - the session survives and reconnects within at
most ~5 minutes, immediately on user activity.
2026-07-10 14:13:04 +02:00

215 lines
7.3 KiB
TypeScript

import { beforeEach, afterEach, describe, expect, it, vi } from 'vitest';
import * as browserNavigation from '@/lib/browser-navigation';
import { useAuthStore } from '../auth-store';
import { useAccountStore } from '../account-store';
type FetchInput = Parameters<typeof fetch>[0];
type FetchInit = Parameters<typeof fetch>[1];
describe('auth-store logout redirects', () => {
beforeEach(() => {
vi.restoreAllMocks();
sessionStorage.clear();
localStorage.clear();
window.history.pushState({}, '', '/en');
useAccountStore.setState({
accounts: [],
activeAccountId: null,
defaultAccountId: null,
});
useAuthStore.setState({
isAuthenticated: false,
isLoading: false,
error: null,
serverUrl: null,
username: null,
client: null,
identities: [],
primaryIdentity: null,
authMode: 'basic',
rememberMe: false,
accessToken: null,
tokenExpiresAt: null,
connectionLost: false,
activeAccountId: null,
});
});
afterEach(() => {
vi.useRealTimers();
});
it('redirects full logout to the locale login page', () => {
const fetchMock = vi.fn().mockResolvedValue({ ok: true, json: async () => ({}) });
vi.stubGlobal('fetch', fetchMock);
const replaceSpy = vi.spyOn(browserNavigation, 'replaceWindowLocation').mockImplementation(() => {});
window.history.pushState({}, '', '/fr/calendar');
useAuthStore.setState({ isAuthenticated: true, authMode: 'basic' });
useAuthStore.getState().logout();
expect(replaceSpy).toHaveBeenCalledWith('/fr/login');
expect(fetchMock).toHaveBeenCalledWith('/api/auth/session?slot=0', { method: 'DELETE', keepalive: true });
});
it('marks session expiry, preserves the current path, and redirects to login when the refresh is rejected (401)', async () => {
vi.useFakeTimers();
const fetchMock = vi.fn(async (input: FetchInput, init?: FetchInit) => {
const url = String(input);
const method = init?.method ?? 'GET';
if (url === '/api/auth/token?slot=0' && method === 'PUT') {
return { ok: false, status: 401, json: async () => ({}) };
}
if (url === '/api/auth/token?slot=0' && method === 'DELETE') {
return { ok: true, json: async () => ({}) };
}
if (url === '/api/auth/session?slot=0' && method === 'DELETE') {
return { ok: true, json: async () => ({}) };
}
throw new Error(`Unexpected fetch call: ${method} ${url}`);
});
vi.stubGlobal('fetch', fetchMock);
const replaceSpy = vi.spyOn(browserNavigation, 'replaceWindowLocation').mockImplementation(() => {});
window.history.pushState({}, '', '/en/calendar?view=day');
useAuthStore.setState({
isAuthenticated: true,
authMode: 'oauth',
activeAccountId: null,
});
await useAuthStore.getState().refreshAccessToken();
await vi.runAllTimersAsync();
expect(sessionStorage.getItem('session_expired')).toBe('true');
expect(sessionStorage.getItem('redirect_after_login')).toBe('/en/calendar?view=day');
expect(replaceSpy).toHaveBeenCalledWith('/en/login');
});
it('keeps the session and schedules a retry when the token endpoint is unavailable (5xx)', async () => {
vi.useFakeTimers();
const fetchMock = vi.fn(async (input: FetchInput, init?: FetchInit) => {
const url = String(input);
const method = init?.method ?? 'GET';
if (url === '/api/auth/token?slot=0' && method === 'PUT') {
return { ok: false, status: 503, json: async () => ({}) };
}
throw new Error(`Unexpected fetch call: ${method} ${url}`);
});
vi.stubGlobal('fetch', fetchMock);
const replaceSpy = vi.spyOn(browserNavigation, 'replaceWindowLocation').mockImplementation(() => {});
useAuthStore.setState({
isAuthenticated: true,
authMode: 'oauth',
activeAccountId: null,
});
const token = await useAuthStore.getState().refreshAccessToken();
expect(token).toBeNull();
expect(useAuthStore.getState().isAuthenticated).toBe(true);
expect(sessionStorage.getItem('session_expired')).toBeNull();
expect(replaceSpy).not.toHaveBeenCalled();
const countPuts = () => fetchMock.mock.calls.filter(
([input, init]) => String(input) === '/api/auth/token?slot=0' && init?.method === 'PUT',
).length;
// A retry is armed: advancing past the ~30 s window fires a second PUT.
await vi.advanceTimersByTimeAsync(31_000);
expect(countPuts()).toBe(2);
expect(useAuthStore.getState().isAuthenticated).toBe(true);
// Backoff: after the second failure the next retry waits ~60 s, not 30.
await vi.advanceTimersByTimeAsync(31_000);
expect(countPuts()).toBe(2);
await vi.advanceTimersByTimeAsync(30_000);
expect(countPuts()).toBe(3);
});
it('stops retrying when the user signs out during the outage (#588)', async () => {
vi.useFakeTimers();
let resolveInFlight: ((value: { ok: boolean; status: number; json: () => Promise<object> }) => void) | undefined;
const fetchMock = vi.fn(async (input: FetchInput, init?: FetchInit) => {
const url = String(input);
const method = init?.method ?? 'GET';
if (url === '/api/auth/token?slot=0' && method === 'PUT') {
return new Promise((resolve) => { resolveInFlight = resolve; });
}
if (method === 'DELETE') {
return { ok: true, json: async () => ({}) };
}
throw new Error(`Unexpected fetch call: ${method} ${url}`);
});
vi.stubGlobal('fetch', fetchMock);
vi.spyOn(browserNavigation, 'replaceWindowLocation').mockImplementation(() => {});
useAuthStore.setState({
isAuthenticated: true,
authMode: 'oauth',
activeAccountId: null,
});
// Refresh goes in flight, then the user signs out before it settles.
const pending = useAuthStore.getState().refreshAccessToken();
useAuthStore.getState().logout();
resolveInFlight!({ ok: false, status: 503, json: async () => ({}) });
await pending;
// The failure lands after the sign-out - no retry may be re-armed.
const countPuts = () => fetchMock.mock.calls.filter(
([input, init]) => String(input) === '/api/auth/token?slot=0' && init?.method === 'PUT',
).length;
expect(countPuts()).toBe(1);
await vi.advanceTimersByTimeAsync(600_000);
expect(countPuts()).toBe(1);
});
it('keeps the session when the refresh request fails with a network error', async () => {
vi.useFakeTimers();
const fetchMock = vi.fn(async (input: FetchInput, init?: FetchInit) => {
const url = String(input);
const method = init?.method ?? 'GET';
if (url === '/api/auth/token?slot=0' && method === 'PUT') {
throw new TypeError('Failed to fetch');
}
throw new Error(`Unexpected fetch call: ${method} ${url}`);
});
vi.stubGlobal('fetch', fetchMock);
const replaceSpy = vi.spyOn(browserNavigation, 'replaceWindowLocation').mockImplementation(() => {});
useAuthStore.setState({
isAuthenticated: true,
authMode: 'oauth',
activeAccountId: null,
});
const token = await useAuthStore.getState().refreshAccessToken();
expect(token).toBeNull();
expect(useAuthStore.getState().isAuthenticated).toBe(true);
expect(sessionStorage.getItem('session_expired')).toBeNull();
expect(replaceSpy).not.toHaveBeenCalled();
});
});