src-advisory/SRCmail
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: omit empty cc/bcc from Email/set so server does not emit bare Cc: header #301

Browse Source
This commit is contained in:
Linus Rath
2026-05-18 16:36:45 +02:00
parent 40f36baf94
commit fa261fecfd
3 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/jmap/client.ts
+7 -4
View File
@@ -2014,8 +2014,8 @@ export class JMAPClient implements IJMAPClient {
const emailData: EmailDraft = {
from: [{ ...(sanitizedFromName ? { name: sanitizedFromName } : {}), email: fromEmail || this.username }],
to: to.map(email => ({ email })),
cc: cc?.map(email => ({ email })),
bcc: bcc?.map(email => ({ email })),
cc: cc?.length ? cc.map(email => ({ email })) : undefined,
bcc: bcc?.length ? bcc.map(email => ({ email })) : undefined,
subject,
keywords: { "$draft": true },
mailboxIds: { [draftsMailbox.id]: true },
@@ -2141,8 +2141,11 @@ export class JMAPClient implements IJMAPClient {
from: [{ ...(sanitizedFromName ? { name: sanitizedFromName } : {}), email: fromEmail || this.username }],
replyTo: identityReplyTo?.length ? identityReplyTo : undefined,
to: to.map(email => ({ email })),
cc: cc?.map(email => ({ email })),
bcc: bcc?.map(email => ({ email })),
// RFC 5322 §3.6.3: To/Cc carry an address-list (non-empty). Sending
// cc:[] makes the server emit a literal `Cc:` header with no addresses,
// which is malformed and a spam signal. Omit the field when empty.
cc: cc?.length ? cc.map(email => ({ email })) : undefined,
bcc: bcc?.length ? bcc.map(email => ({ email })) : undefined,
subject,
inReplyTo: normalizedInReplyTo?.length ? normalizedInReplyTo : undefined,
references: normalizedReferences?.length ? normalizedReferences : undefined,