fix: validate OAuth discovery endpoints against SSRF

This commit is contained in:
Linus Rath
2026-05-18 12:53:43 +02:00
parent 6ebf720688
commit f134766fd1
2 changed files with 82 additions and 0 deletions
+56
View File
@@ -1,6 +1,23 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import type { OAuthMetadata } from '../oauth/discovery';
vi.mock('../security/url-guard', () => ({
isPublicHttpUrl: vi.fn(async (urlString: string) => {
try {
const url = new URL(urlString);
if (url.protocol !== 'http:' && url.protocol !== 'https:') return false;
if (url.username || url.password) return false;
const host = url.hostname.toLowerCase();
if (host === 'localhost' || host.endsWith('.local') || host.endsWith('.internal')) return false;
if (/^(127\.|169\.254\.|10\.|192\.168\.)/.test(host)) return false;
if (host === '::1' || host === '0.0.0.0') return false;
return true;
} catch {
return false;
}
}),
}));
const VALID_METADATA: OAuthMetadata = {
issuer: 'https://auth.example.com',
authorization_endpoint: 'https://auth.example.com/authorize',
@@ -92,6 +109,45 @@ describe('oauth/discovery', () => {
expect(consoleSpy).toHaveBeenCalled();
});
it('rejects metadata pointing at loopback / link-local hosts (SSRF guard)', async () => {
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
vi.stubGlobal('fetch', vi.fn()
.mockResolvedValueOnce({
ok: true,
json: () => Promise.resolve({
issuer: 'https://evil.example.com',
authorization_endpoint: 'https://evil.example.com/authorize',
token_endpoint: 'http://169.254.169.254/latest/meta-data/iam/security-credentials/',
}),
})
.mockResolvedValueOnce({ ok: false, status: 404 }));
const result = await discoverOAuth('https://evil.example.com');
expect(result).toBeNull();
expect(consoleSpy).toHaveBeenCalled();
});
it('rejects metadata pointing at private RFC1918 hosts (SSRF guard)', async () => {
const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
vi.stubGlobal('fetch', vi.fn()
.mockResolvedValueOnce({
ok: true,
json: () => Promise.resolve({
issuer: 'https://evil.example.com',
authorization_endpoint: 'https://evil.example.com/authorize',
token_endpoint: 'https://evil.example.com/token',
revocation_endpoint: 'http://127.0.0.1:9200/_cluster/state',
}),
})
.mockResolvedValueOnce({ ok: false, status: 404 }));
const result = await discoverOAuth('https://private-revoke.example.com');
expect(result).toBeNull();
expect(consoleSpy).toHaveBeenCalled();
});
it('caches results - second call for same server URL does not re-fetch', async () => {
vi.stubGlobal('fetch', vi.fn().mockResolvedValueOnce({
ok: true,