src-advisory/SRCmail
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: only commit recipient on Space when input is a valid email #571

Browse Source
This commit is contained in:
Linus Rath
2026-07-07 23:43:54 +02:00
parent e066698938
commit 8647d709ff
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/email/email-composer.tsx
+10 -1
View File
@@ -48,6 +48,7 @@ import {
waitForPendingUploads, waitForPendingUploads,
type Recipient, type Recipient,
} from "@/lib/email-composer-utils"; } from "@/lib/email-composer-utils";
import { isValidEmail } from "@/lib/validation";
import { RichTextEditor } from "@/components/email/rich-text-editor"; import { RichTextEditor } from "@/components/email/rich-text-editor";
import type { Editor } from "@tiptap/react"; import type { Editor } from "@tiptap/react";
import { htmlToPlainText as htmlToPlainTextShared } from "@/lib/html-to-text"; import { htmlToPlainText as htmlToPlainTextShared } from "@/lib/html-to-text";
@@ -2915,7 +2916,15 @@ function RecipientChipInput({
} }
} }
if ((e.key === ' ' || e.key === 'Enter' || e.key === 'Tab') && inputText.trim()) { // Enter / Tab commit whatever is typed. Space only commits when the input
// is already a complete email address; otherwise Space is a normal
// character so a name search like "John Doe" can continue past the space
// instead of committing "John" as a bogus recipient (#571).
const trimmedInput = inputText.trim();
const commitOnKey =
((e.key === 'Enter' || e.key === 'Tab') && trimmedInput) ||
(e.key === ' ' && isValidEmail(trimmedInput));
if (commitOnKey) {
if (e.key !== 'Tab') e.preventDefault(); if (e.key !== 'Tab') e.preventDefault();
commitCurrentInput(); commitCurrentInput();
if (e.key === 'Tab' && onTab) { if (e.key === 'Tab' && onTab) {