feat: add JMAP FileNode file storage backend and file settings
- Implement JMAP FileNode client methods (get, query, list, create, update, destroy, copy) with Stalwart-compatible flat name encoding - Add FileNode/FileNodeFilter types to JMAP type definitions - Create file-store with Zustand for file management state (navigate, upload, delete, rename, move, cut/copy/paste, undo, favorites) - Add folder tree sidebar component for sidebar navigation layout - Add files settings dialog and settings page component with options for view mode, sort, icons, thumbnails, hidden files, folder layout - Update files page and file browser to support JMAP FileNode backend alongside WebDAV, with folder layout switching and settings integration - Add settings tab for files configuration in the settings page - Add translation keys for file settings, calendar subscriptions, identity deletion, contact deletion, email navigation, and reconnection messages across all 8 locales - Change WebDAV file storage to File storage in availability messages - Enhance translations test to verify source-referenced keys exist in the en locale - Fix duplicate JSX attribute in folder-tree-sidebar
This commit is contained in:
@@ -2,7 +2,8 @@ import fs from 'fs';
|
||||
import path from 'path';
|
||||
import { describe, expect, it } from 'vitest';
|
||||
|
||||
const localesDir = path.resolve(__dirname, '../../locales');
|
||||
const rootDir = path.resolve(__dirname, '../..');
|
||||
const localesDir = path.join(rootDir, 'locales');
|
||||
const referenceLocale = 'en';
|
||||
|
||||
function getLeafKeys(obj: Record<string, unknown>, prefix = ''): string[] {
|
||||
@@ -24,11 +25,74 @@ function loadLocale(locale: string): Record<string, unknown> {
|
||||
return JSON.parse(fs.readFileSync(filePath, 'utf-8'));
|
||||
}
|
||||
|
||||
function resolveKey(obj: Record<string, unknown>, key: string): unknown {
|
||||
return key.split('.').reduce<unknown>((o, p) => (o && typeof o === 'object' ? (o as Record<string, unknown>)[p] : undefined), obj);
|
||||
}
|
||||
|
||||
// Collect source files recursively
|
||||
function getSourceFiles(dir: string): string[] {
|
||||
const results: string[] = [];
|
||||
let entries: fs.Dirent[];
|
||||
try { entries = fs.readdirSync(dir, { withFileTypes: true }); } catch { return results; }
|
||||
for (const entry of entries) {
|
||||
const fullPath = path.join(dir, entry.name);
|
||||
if (entry.isDirectory() && !entry.name.startsWith('.') && entry.name !== 'node_modules' && entry.name !== '__tests__') {
|
||||
results.push(...getSourceFiles(fullPath));
|
||||
} else if (entry.isFile() && /\.(tsx?|jsx?)$/.test(entry.name)) {
|
||||
results.push(fullPath);
|
||||
}
|
||||
}
|
||||
return results;
|
||||
}
|
||||
|
||||
/**
|
||||
* Extract translation keys from source, respecting which variable maps to which namespace.
|
||||
* Handles multiple useTranslations calls per file (even reusing the same variable name
|
||||
* in different functions) by finding, for each t("key") call, the nearest preceding
|
||||
* useTranslations assignment to that variable.
|
||||
*/
|
||||
function extractUsedKeys(filePath: string): string[] {
|
||||
const content = fs.readFileSync(filePath, 'utf-8');
|
||||
const keys: string[] = [];
|
||||
|
||||
// Collect all variable→namespace assignments with their positions
|
||||
const assignRegex = /const\s+(\w+)\s*=\s*useTranslations\(\s*["']([^"']*)["']\s*\)/g;
|
||||
const assignments: { varName: string; namespace: string; index: number }[] = [];
|
||||
let m: RegExpExecArray | null;
|
||||
while ((m = assignRegex.exec(content)) !== null) {
|
||||
assignments.push({ varName: m[1], namespace: m[2], index: m.index });
|
||||
}
|
||||
|
||||
if (assignments.length === 0) return keys;
|
||||
|
||||
// Get unique variable names
|
||||
const varNames = [...new Set(assignments.map((a) => a.varName))];
|
||||
|
||||
// For each variable, find its t("key") calls and resolve namespace by position
|
||||
for (const varName of varNames) {
|
||||
const varAssignments = assignments.filter((a) => a.varName === varName);
|
||||
const callRegex = new RegExp(`\\b${varName}\\(\\s*["']([^"'{}]+)["']`, 'g');
|
||||
while ((m = callRegex.exec(content)) !== null) {
|
||||
const key = m[1];
|
||||
if (key.startsWith('.')) continue;
|
||||
// Find the nearest preceding assignment for this variable
|
||||
const ns = varAssignments
|
||||
.filter((a) => a.index < m!.index)
|
||||
.sort((a, b) => b.index - a.index)[0]?.namespace;
|
||||
if (ns === undefined) continue;
|
||||
keys.push(ns ? `${ns}.${key}` : key);
|
||||
}
|
||||
}
|
||||
|
||||
return [...new Set(keys)];
|
||||
}
|
||||
|
||||
const locales = fs
|
||||
.readdirSync(localesDir)
|
||||
.filter((entry) => fs.statSync(path.join(localesDir, entry)).isDirectory());
|
||||
|
||||
const referenceKeys = getLeafKeys(loadLocale(referenceLocale));
|
||||
const referenceData = loadLocale(referenceLocale);
|
||||
const referenceKeys = getLeafKeys(referenceData);
|
||||
|
||||
describe('translations completeness', () => {
|
||||
it('reference locale (en) should have keys', () => {
|
||||
@@ -52,3 +116,23 @@ describe('translations completeness', () => {
|
||||
expect(extra, `Extra ${extra.length} keys in "${locale}":\n${extra.join('\n')}`).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
describe('translations used in source code exist in en locale', () => {
|
||||
const srcDirs = ['components', 'app', 'hooks', 'lib', 'stores', 'contexts'].map((d) => path.join(rootDir, d));
|
||||
const allFiles = srcDirs.flatMap((d) => getSourceFiles(d));
|
||||
const usedKeys = new Set<string>();
|
||||
for (const f of allFiles) {
|
||||
for (const k of extractUsedKeys(f)) {
|
||||
usedKeys.add(k);
|
||||
}
|
||||
}
|
||||
|
||||
it('all translation keys referenced in source should exist in en locale', () => {
|
||||
const missing = [...usedKeys].sort().filter((key) => resolveKey(referenceData, key) === undefined);
|
||||
|
||||
expect(
|
||||
missing,
|
||||
`${missing.length} translation key(s) used in source code but missing from en locale:\n${missing.join('\n')}`,
|
||||
).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user