feat: add plugin/theme disable gates and move policy controls to their admin pages
- Add `pluginsEnabled` and `themesEnabled` master feature gates to FeatureGates - Move theme policy UI (default theme, built-in/admin theme toggles, user uploads toggle) from policy page to themes admin page - Add plugin policy UI (plugins enabled toggle) to plugins admin page - Remove theme policy section and plugin/theme gates from policy page (with note directing to respective pages) - Hide Themes and Plugins settings tabs when their feature gate is disabled - Fix dark mode visibility of all admin toggle switches (bg-white → bg-background, increase off-state track opacity)
This commit is contained in:
Linus Rath
@@ -2,7 +2,7 @@ import { readFile, writeFile, mkdir, rename } from 'node:fs/promises';
|
||||
import { existsSync } from 'node:fs';
|
||||
import path from 'node:path';
|
||||
import { logger } from '@/lib/logger';
|
||||
import { CONFIG_ENV_MAP, DEFAULT_POLICY, type SettingsPolicy } from './types';
|
||||
import { CONFIG_ENV_MAP, DEFAULT_POLICY, DEFAULT_THEME_POLICY, type SettingsPolicy } from './types';
|
||||
|
||||
function getAdminDir(): string {
|
||||
return process.env.ADMIN_DATA_DIR || path.join(process.cwd(), 'data', 'admin');
|
||||
@@ -30,7 +30,15 @@ class ConfigManager {
|
||||
async load(): Promise<void> {
|
||||
this.adminConfig = await this.readJsonFile('config.json') || {};
|
||||
const policy = await this.readJsonFile('policy.json');
|
||||
this.policyCache = policy ? { ...DEFAULT_POLICY, ...policy } : { ...DEFAULT_POLICY };
|
||||
if (policy) {
|
||||
this.policyCache = {
|
||||
...DEFAULT_POLICY,
|
||||
...policy,
|
||||
themePolicy: { ...DEFAULT_THEME_POLICY, ...(policy.themePolicy || {}) },
|
||||
};
|
||||
} else {
|
||||
this.policyCache = { ...DEFAULT_POLICY };
|
||||
}
|
||||
this.loaded = true;
|
||||
logger.debug('ConfigManager loaded', { configKeys: Object.keys(this.adminConfig).length });
|
||||
}
|
||||
|
||||
@@ -0,0 +1,217 @@
|
||||
import { readFile, writeFile, mkdir, rename, unlink } from 'node:fs/promises';
|
||||
import { existsSync } from 'node:fs';
|
||||
import path from 'node:path';
|
||||
import { logger } from '@/lib/logger';
|
||||
|
||||
function getAdminDir(): string {
|
||||
return process.env.ADMIN_DATA_DIR || path.join(process.cwd(), 'data', 'admin');
|
||||
}
|
||||
|
||||
function getPluginsDir(): string {
|
||||
return path.join(getAdminDir(), 'plugins');
|
||||
}
|
||||
|
||||
function getThemesDir(): string {
|
||||
return path.join(getAdminDir(), 'themes');
|
||||
}
|
||||
|
||||
// ─── Types ───────────────────────────────────────────────────
|
||||
|
||||
export interface ServerPlugin {
|
||||
id: string;
|
||||
name: string;
|
||||
version: string;
|
||||
author: string;
|
||||
description: string;
|
||||
type: string;
|
||||
permissions: string[];
|
||||
entrypoint: string;
|
||||
enabled: boolean;
|
||||
installedAt: string;
|
||||
updatedAt: string;
|
||||
}
|
||||
|
||||
export interface ServerTheme {
|
||||
id: string;
|
||||
name: string;
|
||||
version: string;
|
||||
author: string;
|
||||
description: string;
|
||||
variants: string[];
|
||||
enabled: boolean;
|
||||
installedAt: string;
|
||||
updatedAt: string;
|
||||
}
|
||||
|
||||
interface PluginRegistry {
|
||||
plugins: ServerPlugin[];
|
||||
}
|
||||
|
||||
interface ThemeRegistry {
|
||||
themes: ServerTheme[];
|
||||
}
|
||||
|
||||
// ─── Plugin Registry ─────────────────────────────────────────
|
||||
|
||||
async function ensureDir(dir: string): Promise<void> {
|
||||
if (!existsSync(dir)) {
|
||||
await mkdir(dir, { recursive: true });
|
||||
}
|
||||
}
|
||||
|
||||
async function readJsonFile<T>(filePath: string, fallback: T): Promise<T> {
|
||||
try {
|
||||
const raw = await readFile(filePath, 'utf-8');
|
||||
return JSON.parse(raw);
|
||||
} catch (error) {
|
||||
if ((error as NodeJS.ErrnoException).code === 'ENOENT') return fallback;
|
||||
logger.warn(`Failed to read ${filePath}`, { error: error instanceof Error ? error.message : 'Unknown error' });
|
||||
return fallback;
|
||||
}
|
||||
}
|
||||
|
||||
async function writeJsonFile(filePath: string, data: unknown): Promise<void> {
|
||||
const dir = path.dirname(filePath);
|
||||
await ensureDir(dir);
|
||||
const tmpPath = filePath + '.tmp';
|
||||
await writeFile(tmpPath, JSON.stringify(data, null, 2), 'utf-8');
|
||||
await rename(tmpPath, filePath);
|
||||
}
|
||||
|
||||
// ─── Plugin Operations ───────────────────────────────────────
|
||||
|
||||
const pluginRegistryPath = () => path.join(getPluginsDir(), 'registry.json');
|
||||
|
||||
export async function getPluginRegistry(): Promise<PluginRegistry> {
|
||||
return readJsonFile<PluginRegistry>(pluginRegistryPath(), { plugins: [] });
|
||||
}
|
||||
|
||||
export async function getPlugin(id: string): Promise<ServerPlugin | null> {
|
||||
const registry = await getPluginRegistry();
|
||||
return registry.plugins.find(p => p.id === id) || null;
|
||||
}
|
||||
|
||||
export async function savePlugin(
|
||||
plugin: ServerPlugin,
|
||||
code: string,
|
||||
): Promise<void> {
|
||||
const dir = getPluginsDir();
|
||||
await ensureDir(dir);
|
||||
|
||||
// Save code bundle
|
||||
const bundlePath = path.join(dir, `${plugin.id}.js`);
|
||||
await writeFile(bundlePath, code, 'utf-8');
|
||||
|
||||
// Update registry
|
||||
const registry = await getPluginRegistry();
|
||||
const idx = registry.plugins.findIndex(p => p.id === plugin.id);
|
||||
if (idx >= 0) {
|
||||
registry.plugins[idx] = plugin;
|
||||
} else {
|
||||
registry.plugins.push(plugin);
|
||||
}
|
||||
await writeJsonFile(pluginRegistryPath(), registry);
|
||||
}
|
||||
|
||||
export async function updatePluginMeta(id: string, updates: Partial<Pick<ServerPlugin, 'enabled'>>): Promise<ServerPlugin | null> {
|
||||
const registry = await getPluginRegistry();
|
||||
const idx = registry.plugins.findIndex(p => p.id === id);
|
||||
if (idx < 0) return null;
|
||||
|
||||
registry.plugins[idx] = { ...registry.plugins[idx], ...updates, updatedAt: new Date().toISOString() };
|
||||
await writeJsonFile(pluginRegistryPath(), registry);
|
||||
return registry.plugins[idx];
|
||||
}
|
||||
|
||||
export async function deletePlugin(id: string): Promise<boolean> {
|
||||
const registry = await getPluginRegistry();
|
||||
const idx = registry.plugins.findIndex(p => p.id === id);
|
||||
if (idx < 0) return false;
|
||||
|
||||
registry.plugins.splice(idx, 1);
|
||||
await writeJsonFile(pluginRegistryPath(), registry);
|
||||
|
||||
// Remove bundle file
|
||||
const bundlePath = path.join(getPluginsDir(), `${id}.js`);
|
||||
try { await unlink(bundlePath); } catch { /* ok if missing */ }
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
export async function getPluginBundle(id: string): Promise<string | null> {
|
||||
const bundlePath = path.join(getPluginsDir(), `${id}.js`);
|
||||
try {
|
||||
return await readFile(bundlePath, 'utf-8');
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Theme Operations ────────────────────────────────────────
|
||||
|
||||
const themeRegistryPath = () => path.join(getThemesDir(), 'registry.json');
|
||||
|
||||
export async function getThemeRegistry(): Promise<ThemeRegistry> {
|
||||
return readJsonFile<ThemeRegistry>(themeRegistryPath(), { themes: [] });
|
||||
}
|
||||
|
||||
export async function getTheme(id: string): Promise<ServerTheme | null> {
|
||||
const registry = await getThemeRegistry();
|
||||
return registry.themes.find(t => t.id === id) || null;
|
||||
}
|
||||
|
||||
export async function saveTheme(
|
||||
theme: ServerTheme,
|
||||
css: string,
|
||||
): Promise<void> {
|
||||
const dir = getThemesDir();
|
||||
await ensureDir(dir);
|
||||
|
||||
// Save CSS file
|
||||
const cssPath = path.join(dir, `${theme.id}.css`);
|
||||
await writeFile(cssPath, css, 'utf-8');
|
||||
|
||||
// Update registry
|
||||
const registry = await getThemeRegistry();
|
||||
const idx = registry.themes.findIndex(t => t.id === theme.id);
|
||||
if (idx >= 0) {
|
||||
registry.themes[idx] = theme;
|
||||
} else {
|
||||
registry.themes.push(theme);
|
||||
}
|
||||
await writeJsonFile(themeRegistryPath(), registry);
|
||||
}
|
||||
|
||||
export async function updateThemeMeta(id: string, updates: Partial<Pick<ServerTheme, 'enabled'>>): Promise<ServerTheme | null> {
|
||||
const registry = await getThemeRegistry();
|
||||
const idx = registry.themes.findIndex(t => t.id === id);
|
||||
if (idx < 0) return null;
|
||||
|
||||
registry.themes[idx] = { ...registry.themes[idx], ...updates, updatedAt: new Date().toISOString() };
|
||||
await writeJsonFile(themeRegistryPath(), registry);
|
||||
return registry.themes[idx];
|
||||
}
|
||||
|
||||
export async function deleteTheme(id: string): Promise<boolean> {
|
||||
const registry = await getThemeRegistry();
|
||||
const idx = registry.themes.findIndex(t => t.id === id);
|
||||
if (idx < 0) return false;
|
||||
|
||||
registry.themes.splice(idx, 1);
|
||||
await writeJsonFile(themeRegistryPath(), registry);
|
||||
|
||||
// Remove CSS file
|
||||
const cssPath = path.join(getThemesDir(), `${id}.css`);
|
||||
try { await unlink(cssPath); } catch { /* ok if missing */ }
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
export async function getThemeCSS(id: string): Promise<string | null> {
|
||||
const cssPath = path.join(getThemesDir(), `${id}.css`);
|
||||
try {
|
||||
return await readFile(cssPath, 'utf-8');
|
||||
} catch {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
@@ -23,6 +23,8 @@ export interface SettingRestriction {
|
||||
}
|
||||
|
||||
export interface FeatureGates {
|
||||
pluginsEnabled: boolean;
|
||||
themesEnabled: boolean;
|
||||
sidebarAppsEnabled: boolean;
|
||||
userThemesEnabled: boolean;
|
||||
settingsExportEnabled: boolean;
|
||||
@@ -37,6 +39,8 @@ export interface FeatureGates {
|
||||
}
|
||||
|
||||
export const DEFAULT_FEATURE_GATES: FeatureGates = {
|
||||
pluginsEnabled: true,
|
||||
themesEnabled: true,
|
||||
sidebarAppsEnabled: true,
|
||||
userThemesEnabled: true,
|
||||
settingsExportEnabled: true,
|
||||
@@ -50,16 +54,33 @@ export const DEFAULT_FEATURE_GATES: FeatureGates = {
|
||||
hoverActionsConfigEnabled: true,
|
||||
};
|
||||
|
||||
export interface ThemePolicy {
|
||||
/** Built-in theme IDs that are disabled (hidden from users) */
|
||||
disabledBuiltinThemes: string[];
|
||||
/** Admin-deployed theme IDs that are disabled (hidden from users) */
|
||||
disabledThemes: string[];
|
||||
/** Default theme ID for new users (null = system default) */
|
||||
defaultThemeId: string | null;
|
||||
}
|
||||
|
||||
export const DEFAULT_THEME_POLICY: ThemePolicy = {
|
||||
disabledBuiltinThemes: [],
|
||||
disabledThemes: [],
|
||||
defaultThemeId: null,
|
||||
};
|
||||
|
||||
export interface SettingsPolicy {
|
||||
restrictions: Record<string, SettingRestriction>;
|
||||
features: FeatureGates;
|
||||
defaults: Record<string, unknown>;
|
||||
themePolicy: ThemePolicy;
|
||||
}
|
||||
|
||||
export const DEFAULT_POLICY: SettingsPolicy = {
|
||||
restrictions: {},
|
||||
features: { ...DEFAULT_FEATURE_GATES },
|
||||
defaults: {},
|
||||
themePolicy: { ...DEFAULT_THEME_POLICY },
|
||||
};
|
||||
|
||||
export interface AuditEntry {
|
||||
|
||||
Reference in New Issue
Block a user