fix(ai): turn a bare 'Failed to fetch' into an actionable BYOK error

chatPublic() calls the provider's /chat/completions directly from the renderer. Verified live: a saved profile pointing at platform.deepseek.com (DeepSeek's console) instead of api.deepseek.com (their actual API) fails the CORS preflight outright - 403, no Access-Control-* headers - which surfaces to fetch() as an undifferentiated "Failed to fetch" with no status to inspect. Confirmed the real API and OpenRouter both support being called directly from a browser fine, so the architecture is sound; only the error message was useless. Now names the URL and the likely cause instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-07 13:10:00 +02:00
parent 395fcc27a8
commit 1aa0a4686b
2 changed files with 75 additions and 8 deletions
@@ -0,0 +1,48 @@
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { chatPublic } from '../local-client';
+
+describe('chatPublic', () => {
+  afterEach(() => {
+    vi.unstubAllGlobals();
+  });
+
+  it('turns a network/CORS-level failure into an actionable message naming the Base URL', async () => {
+    vi.stubGlobal('fetch', vi.fn().mockRejectedValue(new TypeError('Failed to fetch')));
+
+    await expect(
+      chatPublic('https://platform.deepseek.com/', 'sk-test', 'deepseek-chat', [
+        { role: 'user', content: 'hi' },
+      ]),
+    ).rejects.toThrow(/Could not reach https:\/\/platform\.deepseek\.com\/chat\/completions/);
+  });
+
+  it('still reports the provider-returned status when the request completes', async () => {
+    vi.stubGlobal(
+      'fetch',
+      vi.fn().mockResolvedValue({ ok: false, status: 401, json: async () => ({}) }),
+    );
+
+    await expect(
+      chatPublic('https://api.deepseek.com', 'sk-bad', 'deepseek-chat', [
+        { role: 'user', content: 'hi' },
+      ]),
+    ).rejects.toThrow('Provider returned 401');
+  });
+
+  it('returns the message content on success', async () => {
+    vi.stubGlobal(
+      'fetch',
+      vi.fn().mockResolvedValue({
+        ok: true,
+        status: 200,
+        json: async () => ({ choices: [{ message: { content: 'hello there' } }] }),
+      }),
+    );
+
+    await expect(
+      chatPublic('https://api.deepseek.com', 'sk-good', 'deepseek-chat', [
+        { role: 'user', content: 'hi' },
+      ]),
+    ).resolves.toBe('hello there');
+  });
+});